Feat: Automatically drop Element suffix from controller names#43
Merged
Feat: Automatically drop Element suffix from controller names#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some code to drop the
Elementsuffix from class names when they get converted to a tag, so for example:HelloWorldElementbecomes<hello-world>UserListElementbecomes<user-list>TeamMembersElementbecomes<team-members>This is a backwards incompatible change, as any previous elements registered with an
Elementsuffix will now have different tag names, but we're still pre 1.0 so this won't necessitate a major version bump.This does not affect any existing classes suffixed with
Controller, they will remain the same.This also updates the docs to reflect these changes. A lot of the docs changes overlap with #42 but we won't close that issue as it has other useful changes.
Relevant docs changes